From 57a50381a25ab768039420d7f36d7e09d1725ca8 Mon Sep 17 00:00:00 2001 From: Jan Lindemann Date: Sun, 7 Jun 2026 08:32:41 +0200 Subject: [PATCH] pkg.sh: upload_pkg(): Don't ignore git push errors After release, pkg.sh pushes the changes to VERSION and HASH upstream. Failures are masked, though, propagate them. Unclear what motivated masking the error. Tracking that down with git blame leads to build-package.sh, which was inherited from ytools, where the change was introduced 2014 with the trust-inspiring comment: attempted fix for error during commit of version files in build-package.sh Signed-off-by: Jan Lindemann --- scripts/pkg.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/pkg.sh b/scripts/pkg.sh index adeeb062..1e213c87 100644 --- a/scripts/pkg.sh +++ b/scripts/pkg.sh @@ -659,7 +659,7 @@ upload_pkg() scm_commit -m "Release $v@`platform`" $TOPDIR/RELEASES $TOPDIR/HASH if [ "$SCM" = git ]; then # Don't use extra options, they might contain -l - JW_PKG_SSH_EXTRA_OPTS="" git push || true + JW_PKG_SSH_EXTRA_OPTS="" git push || fatal "Failed to push changes to RELEASES and HASH" fi }