From 595995e08445c413fc356d709c5413ff86453286 Mon Sep 17 00:00:00 2001 From: Jan Lindemann Date: Mon, 23 Feb 2026 10:36:46 +0100 Subject: [PATCH] jw.pkg.cmds: Replace split('\n') by splitlines() splitlines() removes empty lines, so use it and save some lines of code. Signed-off-by: Jan Lindemann --- src/python/jw/pkg/cmds/distro/lib/rpm.py | 4 +--- src/python/jw/pkg/cmds/projects/CmdGetAuthInfo.py | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/python/jw/pkg/cmds/distro/lib/rpm.py b/src/python/jw/pkg/cmds/distro/lib/rpm.py index 3a1fd428..6ed6d0fa 100644 --- a/src/python/jw/pkg/cmds/distro/lib/rpm.py +++ b/src/python/jw/pkg/cmds/distro/lib/rpm.py @@ -26,9 +26,7 @@ async def all_installed_packages() -> Iterable[Package]: tag_str = '|'.join([f'%{{{tag}}}' for tag in query_tags]) + r'\n' opts.append(tag_str) package_list_str, stderr = await run_rpm('-qa', *opts, sudo=False) - for package_str in package_list_str.split('\n'): - if not package_str: - continue + for package_str in package_list_str.splitlines(): tags = package_str.split('|') ret.append(Package(name=tags[0], vendor=tags[1], packager=tags[2], url=tags[3])) return ret diff --git a/src/python/jw/pkg/cmds/projects/CmdGetAuthInfo.py b/src/python/jw/pkg/cmds/projects/CmdGetAuthInfo.py index 470a8680..a37f0b6c 100644 --- a/src/python/jw/pkg/cmds/projects/CmdGetAuthInfo.py +++ b/src/python/jw/pkg/cmds/projects/CmdGetAuthInfo.py @@ -31,9 +31,7 @@ class CmdGetAuthInfo(Cmd): # export return remotes, stderr = await run_cmd('git', '-C', jw_pkg_dir, 'remote', '-v') result: dict[str, str] = {} - for line in remotes.split('\n'): - if re.match(r'^\s*$', line): - continue + for line in remotes.splitlines(): name, url, typ = re.split(r'\s+', line) if name == 'origin' and typ in ['(pull)', '(fetch)']: # TODO: Use other remotes, too? parsed = urlparse(url)