From 5a1ef45cc040c3044f2fa0f4c3b871adffc51525 Mon Sep 17 00:00:00 2001 From: Jan Lindemann Date: Mon, 1 Jun 2026 13:38:55 +0200 Subject: [PATCH] topdir.mk: Fix: make topdir does only half a job make topdir doesn't reliably regenerate pyrightconfig.json because of .SECONDEXPANSION. Adding a second dollar symbol $$(TD_GENERATE_FILES) solves the problem. Signed-off-by: Jan Lindemann --- make/py-topdir.mk | 3 ++- make/topdir.mk | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/make/py-topdir.mk b/make/py-topdir.mk index a7aaecb0..951762f1 100644 --- a/make/py-topdir.mk +++ b/make/py-topdir.mk @@ -1,4 +1,5 @@ -TD_COPY_FILES += pyproject.toml pyrightconfig.json +TD_COPY_FILES += pyproject.toml +TD_GENERATE_FILES += pyrightconfig.json PY_CHECK_EXCLUDE ?= PY_SRC_ROOT += $(wildcard $(TOPDIR)/src $(TOPDIR)/tools) diff --git a/make/topdir.mk b/make/topdir.mk index 9cac5bb3..77ecaa1f 100644 --- a/make/topdir.mk +++ b/make/topdir.mk @@ -123,6 +123,7 @@ format: topdir check-syntax: topdir check-format: topdir check: check-syntax check-format + @echo "Static code checks completed successfully!" install: topdir.install clean: topdir.clean distclean: topdir.distclean @@ -140,7 +141,7 @@ local-%: FORCE unlocal: $(RM) -f $(shell find . -name local.mk) -topdir: $(TD_GENERATE_FILES) +topdir: $$(TD_GENERATE_FILES) topdir.clean: $(RM) -rf *.done $(TD_GENERATE_FILES) clean: topdir.clean