scripts: Fix shellcheck errors
All checks were successful
CI / Packaging - Kali Linux (pull_request) Successful in 4m23s
CI / Packaging - OpenSUSE Tumbleweed (pull_request) Successful in 4m30s
CI / Packaging test (pull_request) Successful in 0s
CI / Packaging - Kali Linux (push) Successful in 4m2s
CI / Packaging - OpenSUSE Tumbleweed (push) Successful in 4m6s
CI / Packaging test (push) Successful in 0s

Fix shellcheck SC2068 (unquoted array expansions), SC2145 (mixed string/array arguments), SC2328 (redirection in command substitution), SC2173 (untrapable signals), and SC2148 (missing shebang) errors across 14 script files.

Also configure scripts/Makefile with --severity=error so that only errors (not warnings or notes) cause check failures. To be tightened by follow-up commits.

Assisted-by: unsloth/Qwen3.6-35B-A3B-GGUF:IQ4_NL and pi.dev
Signed-off-by: Jan Lindemann <jan@janware.com>
This commit is contained in:
Jan Lindemann 2026-06-25 21:42:22 +02:00
commit 77c746571a
Signed by: Jan Lindemann
GPG key ID: 3750640C9E25DD61
15 changed files with 47 additions and 44 deletions

View file

@ -2,12 +2,12 @@
log()
{
echo $@
printf '%s\n' "$*"
}
fatal()
{
log $@
log "$*"
exit 1
}
@ -47,7 +47,7 @@ date=`date +'%Y%m%d'`
myname=`basename $0`
vcss="git"
opts=$(getopt -o C --long "vcs:" -n $myname -- "$@") || fatal "Failed to parse options $@"
opts=$(getopt -o C --long "vcs:" -n $myname -- "$*") || fatal "Failed to parse options $*"
eval set -- "$opts"
while [ "$1" != -- ]; do
case "$1" in
@ -81,7 +81,7 @@ for vcs in $vcss; do
$ssh $host echo hallo >/dev/null 2>&1 || fatal "Can't ssh into host $host"
done
trap goodbye EXIT INT QUIT KILL
trap goodbye EXIT INT QUIT
scm_status=`mktemp /tmp/$myname""_XXXXXX`
for vcs in $vcss; do