janware/jw-pkg
1
Code Pull requests Activity Actions

App.__find_circular_deps(): Move __flip_dep_graph() out

Browse source 
The __flip_dep_graph(graph) call sits inside the while loop and performs redundant graph flipping on every iteration. Hoist it outside to compute once and reuse the result.
Assisted-by: unsloth/Qwen3.6-35B-A3B-GGUF:IQ4_NL and pi.dev
Signed-off-by: Jan Lindemann <jan@janware.com>
This commit is contained in:
Jan Lindemann 2026-06-30 07:07:03 +02:00
commit 83d6f4b2df
Signed by: Jan Lindemann
GPG key ID: 3750640C9E25DD61
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/python/jw/pkg/App.py
View file

@ -319,11 +319,12 @@ class App(Base):
self.__read_dep_graph(projects, flavours, graph) self.__read_dep_graph(projects, flavours, graph)
unvisited = list(graph.keys()) unvisited = list(graph.keys())
temp: set[str] = set() temp: set[str] = set()
flipped = self.__flip_dep_graph(graph)
while unvisited: while unvisited:
project = unvisited[0] project = unvisited[0]
log(DEBUG, 'Checking circular dependency of', project) log(DEBUG, 'Checking circular dependency of', project)
last = self.__find_circular_deps_recursive( last = self.__find_circular_deps_recursive(
project, self.__flip_dep_graph(graph), unvisited, temp, ret project, flipped, unvisited, temp, ret
) )
if last is not None: if last is not None:
log(DEBUG, f'Found circular dependency below {project}, last is {last}') log(DEBUG, f'Found circular dependency below {project}, last is {last}')