janware/jw-pkg
1
Code Pull requests Activity Actions

lib.distros.suse.Distro._install_local_files(): Use rpm
All checks were successful
CI / Packaging - Kali Linux (pull_request) Successful in 3m2s
Details
CI / Packaging - OpenSUSE Tumbleweed (pull_request) Successful in 3m8s
Details
CI / Packaging test (pull_request) Successful in 0s
Details
CI / Packaging - Kali Linux (push) Successful in 3m5s
Details
CI / Packaging - OpenSUSE Tumbleweed (push) Successful in 3m40s
Details
CI / Packaging test (push) Successful in 0s
Details

Browse source 
OpenSUSE leaves installing local packages to the default implementation in lib.Distro._install_local_files(), which passes the package path to the package manager, i.e. zypper in OpenSUSE's case. That has advantages, namely automatic installation of dependencies, but also disadvantages, namely the attempt to install dependencies even if the package manager is disfunctional, possibly because an installed package containing installation sources is broken.
That could lead to a deadlock when trying to install a fixed package. I see two ways out: Support an additional flag to jw-pkg's install command which selects whether or not dependencies shall be resolved along, or just use rpm directly for all local install attempts.
The latter is the less fancy way to handle this, so as a first step make it the default by overriding suse.Distro._install_local_files().
Signed-off-by: Jan Lindemann <jan@janware.com>
This commit is contained in:
Jan Lindemann 2026-06-15 07:30:51 +02:00
commit bfad94c196
Signed by: Jan Lindemann
GPG key ID: 3750640C9E25DD61
1 changed files with 5 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/python/jw/pkg/lib/distros/suse/Distro.py
View file

@ -73,6 +73,11 @@ class Distro(Base):
cmd += names cmd += names
await self.zypper(cmd) await self.zypper(cmd)
async def _install_local_files(
self, paths: Iterable[str], only_update: bool
) -> None:
await self.rpm(['-U', '--reinstall', *paths])
async def _delete(self, names: Iterable[str]) -> None: async def _delete(self, names: Iterable[str]) -> None:
await self.rpm(['-e', *names], sudo = True) await self.rpm(['-e', *names], sudo = True)