janware/jw-pkg
Watch
1
Code Pull requests Activity Actions

make: Miscellaneous minor fixes and improvements #58

Merged
Jan Lindemann merged 4 commits from jan/feature/20260811-make-miscellaneous-minor-fixes-and-improvements into master 2026-08-11 16:53:42 +02:00 AGit
Conversation 0 Commits 4 Files changed 60 +2 -1
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit f70b14e92b - Show all commits

defs.mk: Disable BUILD_PKG_CONFIG

Prev Next 
BUILD_PKG_CONFIG installs files across project directories into
$(JWBDIR) because of this:

   BUILD_PKG_CONFIGDIR      = $(JWBDIR)/pkgconfig

The concept is currently not used by any downstream project anymore,
hence it lacks sufficient testing at this point. Moreover, it breaks
building repos which are sandboxed to their own root directory,
because it tries to install the generated .pc file back into
$(JWBDIR). The concept itself isn't entirely off, so leave the code
in, disabled, with a comment.

Signed-off-by: Jan Lindemann <jan@janware.com>
Jan Lindemann 2026-08-11 08:07:30 +02:00
commit f70b14e92b
Signed by: Jan Lindemann
GPG key ID: 3750640C9E25DD61

3
make/defs.mk
View file

@ -505,7 +505,8 @@ ifeq ($(CREATE_PKG_CONFIG),true)
BUILD_PKG_CONFIGDIR = $(TOPDIR)/make
endif
LOCAL_PKG_CONFIG = $(PROJECT).pc
BUILD_PKG_CONFIG = $(BUILD_PKG_CONFIGDIR)/$(LOCAL_PKG_CONFIG)
# As of now, this is not used by any downstream project, so disable it to reduce complexity.
#BUILD_PKG_CONFIG = $(BUILD_PKG_CONFIGDIR)/$(LOCAL_PKG_CONFIG)
INSTALLED_PKG_CONFIG = $(addprefix $(INSTALL_PKG_CONFIGDIR)/,$(PKG_CONFIG))
endif