janware/jw-pkg
1
Code Pull requests Activity Actions

pkg.sh: upload_pkg(): Don't ignore git push errors

Browse source 
After release, pkg.sh pushes the changes to VERSION and HASH upstream. Failures are masked, though, propagate them.
Unclear what motivated masking the error. Tracking that down with git blame leads to build-package.sh, which was inherited from ytools, where the change was introduced 2014 with the trust-inspiring comment:
attempted fix for error during commit of version files in build-package.sh
Signed-off-by: Jan Lindemann <jan@janware.com>
This commit is contained in:
Jan Lindemann 2026-06-07 08:32:41 +02:00
commit 57a50381a2
Signed by: Jan Lindemann
GPG key ID: 3750640C9E25DD61
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
scripts/pkg.sh
View file

@ -659,7 +659,7 @@ upload_pkg()
scm_commit -m "Release $v@`platform`" $TOPDIR/RELEASES $TOPDIR/HASH
if [ "$SCM" = git ]; then
# Don't use extra options, they might contain -l
JW_PKG_SSH_EXTRA_OPTS="" git push || true
JW_PKG_SSH_EXTRA_OPTS="" git push || fatal "Failed to push changes to RELEASES and HASH"
fi
}