janware/jw-pkg
1
Code Pull requests Activity Actions

lib.init.detect_modules(): Renovate signature #1

Merged
Jan Lindemann merged 1 commit from jan/feature/20260606-lib-init-detect-modules--renovate-signature into master 2026-06-06 15:46:02 +02:00 AGit
Conversation 0 Commits 1 Files changed 6 +20 -18
Jan Lindemann commented 2026-06-06 15:38:33 +02:00
Owner
Copy link

  • Remove package_name and package_path from the prototype of
    detect_modules(). They can and should be deduced from
    namespace['name'] and namespace['path'], respectively.

  • Make prefix default to None, which signifies "Don't filter by
    prefix".

  • Add an optional extend_namespace parameter, which will make the
    function append the module's name to its path. This
    defaults to True, thereby adding a side effect to the function.
    Which is always wanted in this case for all callers of this
    function.

Signed-off-by: Jan Lindemann jan@janware.com

- Remove package_name and package_path from the prototype of detect_modules(). They can and should be deduced from namespace['__name__'] and namespace['__path__'], respectively. - Make prefix default to None, which signifies "Don't filter by prefix". - Add an optional extend_namespace parameter, which will make the function append the module's __name__ to its __path__. This defaults to True, thereby adding a side effect to the function. Which is always wanted in this case for all callers of this function. Signed-off-by: Jan Lindemann <jan@janware.com>
lib.init.detect_modules(): Renovate signature
All checks were successful
Standard CI tests / Packaging test - Kali Linux (pull_request) Successful in 3m49s
Details
Standard CI tests / Packaging test - OpenSUSE Tumbleweed (pull_request) Successful in 3m36s
Details
Standard CI tests / Packaging test - All supported platforms (pull_request) Successful in 0s
Details
Standard CI tests / Packaging test - Kali Linux (push) Successful in 3m55s
Details
Standard CI tests / Packaging test - OpenSUSE Tumbleweed (push) Successful in 3m26s
Details
Standard CI tests / Packaging test - All supported platforms (push) Successful in 0s
Details
30f6799ddf
 
- Remove package_name and package_path from the prototype of
    detect_modules(). They can and should be deduced from
    namespace['__name__'] and namespace['__path__'], respectively.
  - Make prefix default to None, which signifies "Don't filter by
    prefix".
  - Add an optional extend_namespace parameter, which will make the
    function append the module's __name__ to its __path__. This
    defaults to True, thereby adding a side effect to the function.
    Which is always wanted in the case for all callers of this
    function.
Signed-off-by: Jan Lindemann <jan@janware.com>
Jan Lindemann scheduled this pull request to auto merge when all checks succeed 2026-06-06 15:41:22 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
janware/jw-pkg!1
No description provided.