lib.{App,Cmd}: Pass parent= by name to Cmd* constructors #115

Merged

Jan Lindemann merged 1 commit from jan/feature/20260920-lib-app-cmd-pass-parent-by-name-to-cmd-constructors into master 2026-09-20 12:01:58 +02:00 AGit

Conversation 0 Commits 1 Files changed 2 +2 -2

Jan Lindemann commented 2026-09-20 11:51:26 +02:00

Owner

Copy link

lib.{App,Cmd}: Pass parent= by name to Cmd* constructors

The framework instantiates command classes in two places: the top-level commands in App and the lazily materialized subcommands in Cmd.add_subcommands(). Both pass the parent parameter positionally.

Change that to passing parent by keyword at both call sites. Every command class names its first init() parameter parent, so the keyword form binds the same slot for all of them regardless of parameter order, and it allows a command class to declare parent as keyword-only.

#### lib.{App,Cmd}: Pass parent= by name to Cmd* constructors The framework instantiates command classes in two places: the top-level commands in App and the lazily materialized subcommands in Cmd.add_subcommands(). Both pass the parent parameter positionally. Change that to passing parent by keyword at both call sites. Every command class names its first __init__() parameter parent, so the keyword form binds the same slot for all of them regardless of parameter order, and it allows a command class to declare parent as keyword-only.

Jan Lindemann added 1 commit 2026-09-20 11:51:26 +02:00

lib.{App,Cmd}: Pass parent= by name to Cmd* constructors ... 3602e3ce0d

The framework instantiates command classes in two places: the top-level
commands in App and the lazily materialized subcommands in
Cmd.add_subcommands(). Both pass the parent parameter positionally.

Change that to passing parent by keyword at both call sites. Every command
class names its first __init__() parameter parent, so the keyword form
binds the same slot for all of them regardless of parameter order, and it
allows a command class to declare parent as keyword-only.

Signed-off-by: Jan Lindemann <jan@janware.com>

Jan Lindemann scheduled this pull request to auto merge when all checks succeed 2026-09-20 11:51:27 +02:00

Jan Lindemann merged commit 3602e3ce0d into master 2026-09-20 12:01:58 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

janware/jw-pkg!115

No description provided.