janware/jw-pkg
Watch
1
Code Pull requests Activity Actions

py-ns-dir.mk: Fix PY_UPDATE_INIT_PY ?= false #116

Merged
Jan Lindemann merged 1 commit from jan/feature/20260920-py-ns-dir-mk-fix-py-update-init-py-false into master 2026-09-20 17:59:36 +02:00 AGit
Conversation 0 Commits 1 Files changed 1 +1 -1
Jan Lindemann commented 2026-09-20 17:48:32 +02:00
Owner
Copy link

py-ns-dir.mk: Fix PY_UPDATE_INIT_PY ?= false

The commit message of 29abf14a6 clearly states

As of this commit, this is the case by default, i.e. PY_UPDATE_INIT_PY is set to false in py-ns-dir.mk, maintaining the current behaviour.

The commit's diff then proceeds to set PY_UPDATE_INIT_PY to true. Which is a clear-cut case of my brain doing something different from what my fingers do.

Correcting the commit. Some downstream projects have already consumed this blunder. Not quite sure where that leaves us, but we need to start somewhere with fixing, so I decide to make the code match the documented behaviour, and wait for the fallout to fix.

#### py-ns-dir.mk: Fix PY_UPDATE_INIT_PY ?= false The commit message of 29abf14a6 clearly states As of this commit, this is the case by default, i.e. PY_UPDATE_INIT_PY is set to false in py-ns-dir.mk, maintaining the current behaviour. The commit's diff then proceeds to set PY_UPDATE_INIT_PY to true. Which is a clear-cut case of my brain doing something different from what my fingers do. Correcting the commit. Some downstream projects have already consumed this blunder. Not quite sure where that leaves us, but we need to start somewhere with fixing, so I decide to make the code match the documented behaviour, and wait for the fallout to fix.
py-ns-dir.mk: Fix PY_UPDATE_INIT_PY ?= false
All checks were successful
CI / Packaging - Kali Linux (pull_request) Successful in 6m1s
Details
CI / Packaging - OpenSUSE Tumbleweed (pull_request) Successful in 4m58s
Details
CI / Packaging test (pull_request) Successful in 0s
Details
CI / Packaging - Kali Linux (push) Successful in 9m14s
Details
CI / Packaging - OpenSUSE Tumbleweed (push) Successful in 4m35s
Details
CI / Packaging test (push) Successful in 0s
Details
465b9f5461
 
The commit message of 29abf14a6 clearly states

  As of this commit, this is the case by default, i.e. PY_UPDATE_INIT_PY is
  set to false in py-ns-dir.mk, maintaining the current behaviour.

The commit's diff then proceeds to set PY_UPDATE_INIT_PY to true. Which is
a clear-cut case of my brain doing something different from what my fingers
do.

Correcting the commit. Some downstream projects have already consumed this
blunder. Not quite sure where that leaves us, but we need to start
somewhere with fixing, so I decide to make the code match the documented
behaviour, and wait for the fallout to fix.

Signed-off-by: Jan Lindemann <jan@janware.com>
Jan Lindemann scheduled this pull request to auto merge when all checks succeed 2026-09-20 17:48:33 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
janware/jw-pkg!116
No description provided.