platform.mk: Fix missing common.mk definitions #124

Merged
Jan Lindemann merged 1 commit from jan/feature/20260923-platform-mk-fix-missing-common-mk-definitions into master 2026-09-23 10:13:38 +02:00 AGit
Owner

platform.mk: Fix missing common.mk definitions

platform.mk needs JWB_SCRIPT_DIR before it checks if TARGET_TUPLE is empty, otherwise downstream projects including platform.mk without defs.mk error out (as does jw-bind-zones-ldap-priv via projects.mk:

/usr/bin/python3.13: can't open file '/jw-pkg.py': [Errno 2] No such file or directory ../jw-pkg/make/platform.mk:172: *** TARGET_TUPLE is empty. Schluss..

The fix is to include common.mk earlier in the stack in platform.mk. defs.mk then includes it via projects.mk, so remove direct inclusion from there.

#### platform.mk: Fix missing common.mk definitions platform.mk needs JWB_SCRIPT_DIR before it checks if TARGET_TUPLE is empty, otherwise downstream projects including platform.mk without defs.mk error out (as does jw-bind-zones-ldap-priv via projects.mk: /usr/bin/python3.13: can't open file '/jw-pkg.py': [Errno 2] No such file or directory ../jw-pkg/make/platform.mk:172: *** TARGET_TUPLE is empty. Schluss.. The fix is to include common.mk earlier in the stack in platform.mk. defs.mk then includes it via projects.mk, so remove direct inclusion from there.
platform.mk: Fix missing common.mk definitions
All checks were successful
CI / Packaging - Kali Linux (pull_request) Successful in 10m3s
CI / Packaging - OpenSUSE Tumbleweed (pull_request) Successful in 5m35s
CI / Packaging test (pull_request) Successful in 0s
CI / Packaging - Kali Linux (push) Successful in 8m11s
CI / Packaging - OpenSUSE Tumbleweed (push) Successful in 5m38s
CI / Packaging test (push) Successful in 0s
83905e021c
platform.mk needs JWB_SCRIPT_DIR before it checks if TARGET_TUPLE is empty,
otherwise downstream projects including platform.mk without defs.mk error
out (as does jw-bind-zones-ldap-priv via projects.mk:

   /usr/bin/python3.13: can't open file '/jw-pkg.py': [Errno 2] No such file or directory
  ../jw-pkg/make/platform.mk:172: *** TARGET_TUPLE is empty.  Schluss..

The fix is to include common.mk earlier in the stack in platform.mk.
defs.mk then includes it via projects.mk, so remove direct inclusion from
there.

Signed-off-by: Jan Lindemann <jan@janware.com>
Jan Lindemann scheduled this pull request to auto merge when all checks succeed 2026-09-23 09:57:55 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
janware/jw-pkg!124
No description provided.