topdir.mk: Derive GITIGNORE_PATTERNS_END from TOP #136

Merged

Jan Lindemann merged 1 commit from jan/feature/20261003-topdir-mk-derive-gitignore-patterns-end-from-top into master 2026-10-03 16:02:11 +02:00 AGit

Conversation 0 Commits 1 Files changed 1 +2 -1

Jan Lindemann commented 2026-10-03 15:51:47 +02:00

Owner

• Copy link
• Copy Markdown

topdir.mk: Derive GITIGNORE_PATTERNS_END from TOP

The !-exceptions in the generated .gitignore are computed by a grep pattern that hardcodes the project name, while the top ignore line comes from GITIGNORE_PATTERNS_TOP. A project that overrides GITIGNORE_PATTERNS_TOP - jw-pkg's Makefile sets it to empty - still gets the hardcoded exceptions, and patterns a project adds there get no exceptions at all, so the two can drift apart.

Derive the exception pattern from the same variable:

• new GITIGNORE_PATTERNS_TOP_INV joins the patterns of GITIGNORE_PATTERNS_TOP with |, each wrapped in word boundaries, plus the __init__.py pattern
• GITIGNORE_PATTERNS_END greps the tracked files for that alternation with grep -E instead of a hardcoded BRE, so the dot in __init__.py is literal instead of matching any character

With the default GITIGNORE_PATTERNS_TOP the generated .gitignore is byte-for-byte identical to before.

#### topdir.mk: Derive GITIGNORE_PATTERNS_END from TOP The !-exceptions in the generated `.gitignore` are computed by a grep pattern that hardcodes the project name, while the top ignore line comes from `GITIGNORE_PATTERNS_TOP`. A project that overrides `GITIGNORE_PATTERNS_TOP` - `jw-pkg`'s Makefile sets it to empty - still gets the hardcoded exceptions, and patterns a project adds there get no exceptions at all, so the two can drift apart. Derive the exception pattern from the same variable: - new `GITIGNORE_PATTERNS_TOP_INV` joins the patterns of `GITIGNORE_PATTERNS_TOP` with |, each wrapped in word boundaries, plus the `__init__.py` pattern - `GITIGNORE_PATTERNS_END` greps the tracked files for that alternation with grep -E instead of a hardcoded BRE, so the dot in `__init__.py` is literal instead of matching any character With the default `GITIGNORE_PATTERNS_TOP` the generated `.gitignore` is byte-for-byte identical to before.

Jan Lindemann added 1 commit 2026-10-03 15:51:47 +02:00

topdir.mk: Derive GITIGNORE_PATTERNS_END from TOP ... ce3045e081

The !-exceptions in the generated .gitignore are computed by a grep pattern
that hardcodes the project name, while the top ignore line comes from
GITIGNORE_PATTERNS_TOP. A project that overrides GITIGNORE_PATTERNS_TOP -
jw-pkg's Makefile sets it to empty - still gets the hardcoded exceptions,
and patterns a project adds there get no exceptions at all, so the two can
drift apart.

Derive the exception pattern from the same variable:

- new GITIGNORE_PATTERNS_TOP_INV joins the patterns of
  GITIGNORE_PATTERNS_TOP with |, each wrapped in word boundaries, plus the
  __init__.py pattern
- GITIGNORE_PATTERNS_END greps the tracked files for that alternation with
  grep -E instead of a hardcoded BRE, so the dot in __init__.py is literal
  instead of matching any character

With the default GITIGNORE_PATTERNS_TOP the generated .gitignore is
byte-for-byte identical to before.

Assisted-by: unsloth/Qwen3.8-27B-GGUF:Q4_K_M with pi.dev v1.0.0
Signed-off-by: Jan Lindemann <jan@janware.com>

Jan Lindemann scheduled this pull request to auto merge when all checks succeed 2026-10-03 15:51:48 +02:00

Jan Lindemann merged commit ce3045e081 into master 2026-10-03 16:02:11 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

janware/jw-pkg!136

No description provided.