test/integration/jw-pkg: Rename to jw_pkg for mypy module names #141

Merged

Jan Lindemann merged 2 commits from jan/fix/20261016-test-integration-jw-pkg-rename-to-jw-pkg-for-mypy-module-names into master 2026-10-16 09:35:47 +02:00 AGit

Conversation 0 Commits 2 Files changed 28 +1 -2

Jan Lindemann commented 2026-10-16 09:19:49 +02:00

Owner

• Copy link
• Copy Markdown

Rename the integration test tree test/integration/jw-pkg/ to the valid Python identifier jw_pkg so mypy can derive module names from the full path: below a path component that is not a valid identifier, the module name falls back to the bare file name, and the two same-named test.py drivers collided. The rename also restores the secrets driver to the test.py name like all the others, and the second commit carries the miniscule make format fallout of the new paths.

test/integration/jw-pkg -> test/integration/jw_pkg

The mypy module names of the test tree derive from the full path, anchored by the top-level test/__init__.py, but a file below a path component that is not a valid identifier - the dashes in jw-pkg - falls back to the bare file name, so two same-named test.py drivers collide (the duplicate module error that drove the runme.py and main.py renames).

Rename the directory a sane Python name - jw_pkg, that's the better fix. Then name the driver test.py like all the others for consistency.

test/integration/jw-pkg/secrets: Fix make format fallout

Fix a miniscule make format churn.

Rename the integration test tree `test/integration/jw-pkg/` to the valid Python identifier `jw_pkg` so `mypy` can derive module names from the full path: below a path component that is not a valid identifier, the module name falls back to the bare file name, and the two same-named `test.py` drivers collided. The rename also restores the secrets driver to the `test.py` name like all the others, and the second commit carries the miniscule `make format` fallout of the new paths. #### test/integration/jw-pkg -> test/integration/jw_pkg The `mypy` module names of the test tree derive from the full path, anchored by the top-level `test/__init__.py`, but a file below a path component that is not a valid identifier - the dashes in `jw-pkg` - falls back to the bare file name, so two same-named `test.py` drivers collide (the duplicate module error that drove the `runme.py` and `main.py` renames). Rename the directory a sane Python name - `jw_pkg`, that's the better fix. Then name the driver `test.py` like all the others for consistency. #### test/integration/jw-pkg/secrets: Fix make format fallout Fix a miniscule `make format` churn.

Jan Lindemann added 2 commits 2026-10-16 09:19:49 +02:00

test/integration/jw-pkg -> test/integration/jw_pkg ... 61c9479e79

The mypy module names of the test tree derive from the full path, anchored
by the top-level test/__init__.py, but a file below a path component that
is not a valid identifier - the dashes in jw-pkg - falls back to the bare
file name, so two same-named test.py drivers collide (the duplicate module
error that drove the runme.py and main.py renames).

Rename the directory a sane Python name - jw_pkg, that's the better fix.
Then name the driver test.py like all the others for consistency.

Signed-off-by: Jan Lindemann <jan@janware.com>

test/integration/jw-pkg/secrets: Fix make format fallout ... 63f0fef12e

Fix a miniscule make format churn.

Signed-off-by: Jan Lindemann <jan@janware.com>
Assisted-by: unsloth/Qwen3.8-27B-GGUF:Q4_K_M with pi.dev v1.1.0

Jan Lindemann scheduled this pull request to auto merge when all checks succeed 2026-10-16 09:19:50 +02:00

Jan Lindemann merged commit 63f0fef12e into master 2026-10-16 09:35:47 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

janware/jw-pkg!141

No description provided.