topdir.mk: Remove --skip-excluded from install targets #150

Merged

Jan Lindemann merged 1 commit from jan/fix/20261018-topdir-mk-remove-skip-excluded-from-install-targets into master 2026-10-18 18:21:52 +02:00 AGit

Conversation 0 Commits 1 Files changed 1 +3 -3

Jan Lindemann commented 2026-10-18 18:05:45 +02:00

Owner

• Copy link
• Copy Markdown

topdir.mk: Remove --skip-excluded from install targets

Using --skip-excluded in pkg-install-*'s recipes breaks CI, and here's how: During a CI run, a package is expected to be testable with only jw-pkg and the package itself installed in the test environment. testable here means that it's possible to install the necessary dependencies with make pkg-install-* commands before building. That condition is inherently always met by packages which have only jw-pkg as its only dependency. But it's not true for packages with intermediate packages in their dependency tree. For for those packages it's not advisable to pass --skip-excluded to the dependency detection, because that will cause the resolver to try and find the intermediate's project.conf to read its [build].excluded section. Which fails because that intermediate is neither installed nor checked out.

So, until there's another mechansim in place which allows excluding uninstalled packages (caller-supplied knowledge, reading remote repositories, package-manager-like package metadata cache), drop --skip-excluded from the pkg-install-* targets' recipes.

#### topdir.mk: Remove --skip-excluded from install targets Using `--skip-excluded` in pkg-install-\*'s recipes breaks CI, and here's how: During a CI run, a package is expected to be testable with only `jw-pkg` and the package itself installed in the test environment. `testable` here means that it's possible to install the necessary dependencies with make pkg-install-\* commands before building. That condition is inherently always met by packages which have only `jw-pkg` as its only dependency. But it's not true for packages with intermediate packages in their dependency tree. For for those packages it's not advisable to pass `--skip-excluded` to the dependency detection, because that will cause the resolver to try and find the intermediate's `project.conf` to read its [build].excluded section. Which fails because that intermediate is neither installed nor checked out. So, until there's another mechansim in place which allows excluding uninstalled packages (caller-supplied knowledge, reading remote repositories, package-manager-like package metadata cache), drop `--skip-excluded` from the pkg-install-* targets' recipes.

Jan Lindemann added 1 commit 2026-10-18 18:05:45 +02:00

topdir.mk: Remove --skip-excluded from install targets ... a3186489e6

Using --skip-excluded in pkg-install-*'s recipes breaks CI, and here's how:
During a CI run, a package is expected to be testable with only jw-pkg and
the package itself installed in the test environment. "testable" here means
that it's possible to install the necessary dependencies with make
pkg-install-* commands before building. That condition is inherently always
met by packages which have only jw-pkg as its only dependency. But it's not
true for packages with intermediate packages in their dependency tree. For
for those packages it's not advisable to pass --skip-excluded to the
dependency detection, because that will cause the resolver to try and find
the intermediate's project.conf to read its [build].excluded section.
Which fails because that intermediate is neither installed nor checked out.

So, until there's another mechansim in place which allows excluding
uninstalled packages (caller-supplied knowledge, reading remote
repositories, package-manager-like package metadata cache), drop
--skip-excluded from the pkg-install-* targets' recipes.

Signed-off-by: Jan Lindemann <jan@janware.com>

Jan Lindemann scheduled this pull request to auto merge when all checks succeed 2026-10-18 18:05:46 +02:00

Jan Lindemann canceled auto merging this pull request when all checks succeed 2026-10-18 18:07:58 +02:00

Jan Lindemann force-pushed jan/fix/20261018-topdir-mk-remove-skip-excluded-from-install-targets from a3186489e6 to 2d0544743a 2026-10-18 18:10:54 +02:00 Compare

Jan Lindemann merged commit 2d0544743a into master 2026-10-18 18:21:52 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

janware/jw-pkg!150

No description provided.