common.mk: Set WHICH to command -v #151

Merged

Jan Lindemann merged 1 commit from jan/feature/20261020-common-mk-set-which-to-command-v into master 2026-10-20 09:14:37 +02:00 AGit

Conversation 0 Commits 1 Files changed 5 +7 -7

Jan Lindemann commented 2026-10-20 09:03:09 +02:00

Owner

• Copy link
• Copy Markdown

common.mk: Set WHICH to command -v

defs.mk derives WHICH from the external which binary, first from a hardcoded /usr/bin/which path and then with a which which fallback, while the probes for time, ruff, pyright, and python3 call which directly. Systems that do not ship the which package, such as minimal containers, are left to the shell's PATH search.

Define WHICH once in common.mk as the POSIX command -v builtin and drop the old definition from defs.mk. Route the remaining direct which calls through $(WHICH):

• projects-dir.mk: TIME probe
• py-check.mk: PY_CHECK_RUFF and PY_CHECK_PYRIGHT probes
• py-version.mk: PYTHON lookup

command -v runs in the /bin/sh that $(shell) already uses, so the build no longer depends on the which package. The builtin names that command -v reports for echo, test, pwd, and printf are safe, because every use of those variables runs through the shell, and the bash time keyword keeps the -p output format identical to the GNU time binary.

#### common.mk: Set WHICH to command -v defs.mk derives WHICH from the external which binary, first from a hardcoded /usr/bin/which path and then with a `which which` fallback, while the probes for time, ruff, pyright, and python3 call which directly. Systems that do not ship the which package, such as minimal containers, are left to the shell's PATH search. Define `WHICH` once in `common.mk` as the `POSIX` command -v builtin and drop the old definition from `defs.mk`. Route the remaining direct which calls through `$(WHICH)`: - `projects-dir.mk`: `TIME` probe - `py-check.mk`: `PY_CHECK_RUFF` and `PY_CHECK_PYRIGHT` probes - `py-version.mk`: `PYTHON` lookup command -v runs in the /bin/sh that `$(shell)` already uses, so the build no longer depends on the which package. The builtin names that command -v reports for echo, test, pwd, and printf are safe, because every use of those variables runs through the shell, and the bash time keyword keeps the -p output format identical to the GNU time binary.

Jan Lindemann added 1 commit 2026-10-20 09:03:09 +02:00

common.mk: Set WHICH to command -v ... f5249a58ef

defs.mk derives WHICH from the external which binary, first from a
hardcoded /usr/bin/which path and then with a `which which` fallback, while
the probes for time, ruff, pyright, and python3 call which directly.
Systems that do not ship the which package, such as minimal containers, are
left to the shell's PATH search.

Define WHICH once in common.mk as the POSIX command -v builtin and drop the
old definition from defs.mk. Route the remaining direct which calls through
$(WHICH):

- projects-dir.mk: TIME probe
- py-check.mk: PY_CHECK_RUFF and PY_CHECK_PYRIGHT probes
- py-version.mk: PYTHON lookup

command -v runs in the /bin/sh that $(shell) already uses, so the build no
longer depends on the which package. The builtin names that command -v
reports for echo, test, pwd, and printf are safe, because every use of
those variables runs through the shell, and the bash time keyword keeps the
-p output format identical to the GNU time binary.

Assisted-by: unsloth/Qwen3.8-27B-GGUF:Q4_K_M with pi.dev v1.3.0
Signed-off-by: Jan Lindemann <jan@janware.com>

Jan Lindemann scheduled this pull request to auto merge when all checks succeed 2026-10-20 09:03:10 +02:00

Jan Lindemann merged commit f5249a58ef into master 2026-10-20 09:14:37 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

janware/jw-pkg!151

No description provided.