janware/jw-pkg
Watch
1
Code Pull requests Activity Actions

defs.mk: Make common PKG_CONFIG build dir opt-in #152

Merged
Jan Lindemann merged 1 commit from jan/fix/20261020-defs-mk-make-common-pkg-config-build-dir-opt-in into master 2026-10-20 10:22:11 +02:00 AGit
Conversation 0 Commits 1 Files changed 1 +5 -5
Jan Lindemann commented 2026-10-20 10:11:29 +02:00
Owner

defs.mk: Make common PKG_CONFIG build dir opt-in

f70b14e92 ("defs.mk: Disable BUILD_PKG_CONFIG") disabled the BUILD_PKG_CONFIG copy target, but the dir_build_PKG_CONFIG.done rule still runs mkdir -p $(BUILD_PKG_CONFIGDIR), and that directory is keyed off DEVELOPMENT. A dev-version downstream package built against an installed, read-only jw-pkg therefore resolves BUILD_PKG_CONFIGDIR to $(JWBDIR)/pkgconfig and fails the build with "mkdir: Permission denied".

Default BUILD_PKG_CONFIGDIR to project-local $(TOPDIR)/make regardless of DEVELOPMENT, and leave it overridable so that a self-contained build over multiple projects can point it at some shared $(JWBDIR)/pkgconfig directory at the user's discretion.

#### defs.mk: Make common PKG_CONFIG build dir opt-in f70b14e92 ("defs.mk: Disable BUILD_PKG_CONFIG") disabled the BUILD_PKG_CONFIG copy target, but the dir_build_PKG_CONFIG.done rule still runs `mkdir -p $(BUILD_PKG_CONFIGDIR)`, and that directory is keyed off DEVELOPMENT. A dev-version downstream package built against an installed, read-only jw-pkg therefore resolves BUILD_PKG_CONFIGDIR to $(JWBDIR)/pkgconfig and fails the build with "mkdir: Permission denied". Default `BUILD_PKG_CONFIGDIR` to project-local `$(TOPDIR)`/make regardless of `DEVELOPMENT`, and leave it overridable so that a self-contained build over multiple projects can point it at some shared `$(JWBDIR)`/pkgconfig directory at the user's discretion.
defs.mk: Make common PKG_CONFIG build dir opt-in
All checks were successful
CI / Packaging - Kali Linux (pull_request) Successful in 5m21s
Details
CI / Packaging - OpenSUSE Tumbleweed (pull_request) Successful in 5m16s
Details
CI / Packaging test (pull_request) Successful in 0s
Details
CI / Packaging - Kali Linux (push) Successful in 4m56s
Details
CI / Packaging - OpenSUSE Tumbleweed (push) Successful in 5m13s
Details
CI / Packaging test (push) Successful in 0s
Details
944df09aa7
 
f70b14e92 ("defs.mk: Disable BUILD_PKG_CONFIG") disabled the
BUILD_PKG_CONFIG copy target, but the dir_build_PKG_CONFIG.done rule
still runs `mkdir -p $(BUILD_PKG_CONFIGDIR)`, and that directory is
keyed off DEVELOPMENT. A dev-version downstream package built against an
installed, read-only jw-pkg therefore resolves BUILD_PKG_CONFIGDIR to
$(JWBDIR)/pkgconfig and fails the build with "mkdir: Permission denied".

Default BUILD_PKG_CONFIGDIR to project-local $(TOPDIR)/make regardless of
DEVELOPMENT, and leave it overridable so that a self-contained build over
multiple projects can point it at some shared $(JWBDIR)/pkgconfig
directory at the user's discretion.

Signed-off-by: Jan Lindemann <jan@janware.com>
Jan Lindemann scheduled this pull request to auto merge when all checks succeed 2026-10-20 10:11:30 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
janware/jw-pkg!152
No description provided.