janware/jw-pkg
Watch
1
Code Pull requests Activity Actions

Miscellaneous minor fixes #47

Merged
Jan Lindemann merged 6 commits from jan/feature/20260722-fix/20260722-miscellaneous-minor-fixes into master 2026-07-22 11:15:30 +02:00 AGit
Conversation 0 Commits 6 Files changed 7 +56 -39
Jan Lindemann commented 2026-07-22 11:06:59 +02:00
Owner
Copy link

This PR brings miscellaneous non-critical fixes and improvements across the entire package. All in Python code, except for one shell script (create-mkspec.sh).

lib.distros.suse.Distro: Fix duplicate zypper opts

In non-interactive mode, "zypper dup" runs with the options --force-resolution and --auto-agree-with-licenses duplicated, fix that.

lib.Types: Exception log beautification

Be a bit more verbose if a broken (i.e. non-class-type) type filter parameter gets passed.

cmds.projects.CmdBuild: Code and log beautification

Improve CmdBuild some more:

  • Fix more broken f-strings
  • Better varable name prereq_type -> dep_flavour
  • Add stricter typing
  • Beautify logging

create-mkspec.sh: Tolerate comma-separated subpackages

subpackages = "run, devel" is not tolerated by create-mkspec.sh. It expects "run devel", which goes against the grain of the other metadata, so make it at least tolerate the more common comma-separated variant.

cmds.CmdPlatform: Fix typo "comamnds" -> "commands"

CmdPlatform's help message contains the string "comamnds", fix that.

lib.ProjectConf: Remove empty line

yapf complains about a superfluous empty line, remove it.

This PR brings miscellaneous non-critical fixes and improvements across the entire package. All in Python code, except for one shell script (create-mkspec.sh). #### lib.distros.suse.Distro: Fix duplicate zypper opts In non-interactive mode, "zypper dup" runs with the options --force-resolution and --auto-agree-with-licenses duplicated, fix that. #### lib.Types: Exception log beautification Be a bit more verbose if a broken (i.e. non-class-type) type filter parameter gets passed. #### cmds.projects.CmdBuild: Code and log beautification Improve CmdBuild some more: - Fix more broken f-strings - Better varable name prereq_type -> dep_flavour - Add stricter typing - Beautify logging #### create-mkspec.sh: Tolerate comma-separated subpackages subpackages = "run, devel" is not tolerated by create-mkspec.sh. It expects "run devel", which goes against the grain of the other metadata, so make it at least tolerate the more common comma-separated variant. #### cmds.CmdPlatform: Fix typo "comamnds" -> "commands" CmdPlatform's help message contains the string "comamnds", fix that. #### lib.ProjectConf: Remove empty line yapf complains about a superfluous empty line, remove it. 
yapf complains about a superfluous empty line, remove it.

Signed-off-by: Jan Lindemann <jan@janware.com>
CmdPlatform's help message contains the string "comamnds", fix that.

Signed-off-by: Jan Lindemann <jan@janware.com>
subpackages = "run, devel" is not tolerated by create-mkspec.sh. It
expects "run devel", which goes against the grain of the other
metadata, so make it at least tolerate the more common
comma-separated variant.

Signed-off-by: Jan Lindemann <jan@janware.com>
Improve CmdBuild some more:

 - Fix more broken f-strings
 - Better varable name prereq_type -> dep_flavour
 - Add stricter typing
 - Beautify logging

Signed-off-by: Jan Lindemann <jan@janware.com>
Be a bit more verbose if a broken (i.e. non-class-type) type filter
parameter gets passed.

Signed-off-by: Jan Lindemann <jan@janware.com>
lib.distros.suse.Distro: Fix duplicate zypper opts
All checks were successful
CI / Packaging - Kali Linux (pull_request) Successful in 4m16s
Details
CI / Packaging - OpenSUSE Tumbleweed (pull_request) Successful in 4m10s
Details
CI / Packaging test (pull_request) Successful in 0s
Details
CI / Packaging - Kali Linux (push) Successful in 3m48s
Details
CI / Packaging - OpenSUSE Tumbleweed (push) Successful in 4m17s
Details
CI / Packaging test (push) Successful in 0s
Details
2c38c8a144
 
In non-interactive mode, "zypper dup" runs with the options
--force-resolution and --auto-agree-with-licenses duplicated, fix
that.

Signed-off-by: Jan Lindemann <jan@janware.com>
Jan Lindemann scheduled this pull request to auto merge when all checks succeed 2026-07-22 11:07:00 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
janware/jw-pkg!47
No description provided.