lib.App: Fix --help with required top-level args #65

Merged

Jan Lindemann merged 1 commit from jan/feature/20260817-lib-app-fix-help-with-required-top-level-args into master 2026-08-17 12:10:37 +02:00 AGit

Conversation 0 Commits 1 Files changed 1 +10 -5

Jan Lindemann commented 2026-08-17 12:02:06 +02:00

Owner

Copy link

lib.App: Fix --help with required top-level args

_build_parser() does an early parse_known_args() to configure logging from the command line, but that call also enforces the top-level required arguments. --help is registered only after the early parse so the subcommands are present in the rendered help, so an app with a required top-level positional, such as a root Cmd that takes a config-file, exits with "required: config-file" on --help before the final parse_args() in __run() can handle it.

Skip the early parse when help or shell completion is requested (the add_all_parsers flag, already set for -h, --help, and argcomplete). The subcommands and --help are still registered, and the final parse_args() shows the help without enforcing the required arguments. The log-flag configuration and the running-command debug line move inside the guard; neither help nor completion logs, so they do not need them.

#### lib.App: Fix --help with required top-level args _build_parser() does an early parse_known_args() to configure logging from the command line, but that call also enforces the top-level required arguments. --help is registered only after the early parse so the subcommands are present in the rendered help, so an app with a required top-level positional, such as a root Cmd that takes a config-file, exits with "required: config-file" on --help before the final parse_args() in __run() can handle it. Skip the early parse when help or shell completion is requested (the add_all_parsers flag, already set for -h, --help, and argcomplete). The subcommands and --help are still registered, and the final parse_args() shows the help without enforcing the required arguments. The log-flag configuration and the running-command debug line move inside the guard; neither help nor completion logs, so they do not need them.

Jan Lindemann added 1 commit 2026-08-17 12:02:06 +02:00

lib.App: Fix --help with required top-level args ... ee332c9d70

_build_parser() does an early parse_known_args() to configure logging
from the command line, but that call also enforces the top-level
required arguments. --help is registered only after the early parse so
the subcommands are present in the rendered help, so an app with a
required top-level positional, such as a root Cmd that takes a
config-file, exits with "required: config-file" on --help before the
final parse_args() in __run() can handle it.

Skip the early parse when help or shell completion is requested (the
add_all_parsers flag, already set for -h, --help, and argcomplete). The
subcommands and --help are still registered, and the final parse_args()
shows the help without enforcing the required arguments. The log-flag
configuration and the running-command debug line move inside the guard;
neither help nor completion logs, so they do not need them.

Assisted-by: pi <unsloth/Qwen3.8-27B-GGUF:Q4_K_M>
Signed-off-by: Jan Lindemann <jan@janware.com>

Jan Lindemann scheduled this pull request to auto merge when all checks succeed 2026-08-17 12:02:07 +02:00

Jan Lindemann merged commit ee332c9d70 into master 2026-08-17 12:10:37 +02:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

janware/jw-pkg!65

No description provided.