janware/jw-pkg
1
Code Pull requests Activity Actions

App.get_libname(): Don't use get_proj_refs() #7

Merged
Jan Lindemann merged 2 commits from jan/feature/20260608-app-get-libname-don-t-use-get-proj-refs into master 2026-06-08 20:49:04 +02:00 AGit
Conversation 0 Commits 2 Files changed 2 +36 -40
Jan Lindemann commented 2026-06-08 20:42:30 +02:00
Owner
Copy link

App.__get_project_refs(): Code beautification

In __get_project_refs():

  • Rename variable dep and deps to val and vals, respectively, because that's more what they are values of key-value pairs. In some cases that can represent dependencies, in some case other things.

  • Make a scope case distinction a little clearer by mentioning all possible cases in a match / case block

App.get_libname(): Don't use get_proj_refs()

App.get_projects_refs() is a versatile tool, but what it does isn't obvious. Use the simpler method .get_value() instead for get_libname(), and return None if a project doesn't provide a linkable library.

This is similar to fix aadcdfb5f.

#### App.__get_project_refs(): Code beautification In __get_project_refs(): - Rename variable dep and deps to val and vals, respectively, because that's more what they are values of key-value pairs. In some cases that can represent dependencies, in some case other things. - Make a scope case distinction a little clearer by mentioning all possible cases in a match / case block #### App.get_libname(): Don't use get_proj_refs() App.get_projects_refs() is a versatile tool, but what it does isn't obvious. Use the simpler method .get_value() instead for get_libname(), and return None if a project doesn't provide a linkable library. This is similar to fix aadcdfb5f. 
In __get_project_refs():
  - Rename variable dep and deps to val and vals, respectively,
    because that's more what they are values of key-value pairs. In
    some cases that can represent dependencies, in some case other
    things.
  - Make a scope case distinction a little clearer by mentioning all
    possible cases in a match / case block
Signed-off-by: Jan Lindemann <jan@janware.com>
App.get_libname(): Don't use get_proj_refs()
All checks were successful
CI / Packaging - Kali Linux (pull_request) Successful in 3m16s
Details
CI / Packaging - OpenSUSE Tumbleweed (pull_request) Successful in 3m12s
Details
CI / Packaging test (pull_request) Successful in 0s
Details
CI / Packaging - Kali Linux (push) Successful in 3m17s
Details
CI / Packaging - OpenSUSE Tumbleweed (push) Successful in 3m18s
Details
CI / Packaging test (push) Successful in 0s
Details
3f47abb29a
 
App.get_projects_refs() is a versatile tool, but what it does isn't obvious. Use the simpler method .get_value() instead for get_libname(), and return None if a project doesn't provide a linkable library.
This is similar to fix aadcdfb5f.
Signed-off-by: Jan Lindemann <jan@janware.com>
Jan Lindemann scheduled this pull request to auto merge when all checks succeed 2026-06-08 20:42:31 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
janware/jw-pkg!7
No description provided.