janware/jw-pkg
1
Code Pull requests Activity Actions

App.get_libname(): Don't use get_proj_refs() #7

Merged
Jan Lindemann merged 2 commits from jan/feature/20260608-app-get-libname-don-t-use-get-proj-refs into master 2026-06-08 20:49:04 +02:00 AGit
Conversation 0 Commits 2 Files changed 2 +22 -21
1 changed files with 22 additions and 21 deletions
Download patch file Download diff file Expand all files Collapse all files
Showing only changes of commit c538447cc5 - Show all commits

App.__get_project_refs(): Code beautification

Prev Next 
In __get_project_refs():
  - Rename variable dep and deps to val and vals, respectively,
    because that's more what they are values of key-value pairs. In
    some cases that can represent dependencies, in some case other
    things.
  - Make a scope case distinction a little clearer by mentioning all
    possible cases in a match / case block
Signed-off-by: Jan Lindemann <jan@janware.com>
Jan Lindemann 2026-06-06 14:53:02 +02:00
commit c538447cc5
Signed by: Jan Lindemann
GPG key ID: 3750640C9E25DD61

43
src/python/jw/pkg/App.py
View file

@ -188,33 +188,34 @@ class App(Base):
buf.append(spec) buf.append(spec)
return return
visited.add(spec) visited.add(spec)
deps = self.get_value(name, section, key) vals = self.get_value(name, section, key)
log( log(
DEBUG, DEBUG,
( (
f'name={name}, section={section}, key={key}, deps={deps}, ' f'name={name}, section={section}, key={key}, deps={vals}, '
f'scope={scope.name}, visited={visited}' f'scope={scope.name}, visited={visited}'
), ),
) )
if deps and scope != Scope.Self: vals_list = vals.split(',') if vals else []
if scope == Scope.One: match scope:
subscope = Scope.Self case Scope.Self:
else: buf += vals_list
subscope = Scope.Subtree case Scope.One | Scope.Subtree:
for dep in deps.split(','): subscope = scope.Self if scope == Scope.One else scope
dep = dep.strip() for val in vals_list:
if not (len(dep)): val = val.strip()
continue if not (len(val)):
self.__get_project_refs_cached( continue
buf, self.__get_project_refs_cached(
visited, buf,
dep, visited,
section, val,
key, section,
add_self = True, key,
scope = subscope, add_self = True,
names_only = names_only, scope = subscope,
) names_only = names_only,
)
if add_self: if add_self:
buf.append(spec) buf.append(spec)